Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: webkit/glue/plugins/webplugin_delegate_impl_gtk.cc

Issue 195095: linux: remove a dcheck that is hit with old plugins (Closed)
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/plugins/webplugin_delegate_impl_gtk.cc
diff --git a/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc b/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc
index 76736996053daaec758d89500fcccad732b5e442..f4e802962195e78bc2e1980c87b769da11dd1ab8 100644
--- a/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc
+++ b/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc
@@ -120,9 +120,8 @@ bool WebPluginDelegateImpl::WindowedCreatePlugin() {
// single byte bool, use an int instead.
int xembed;
NPError err = instance_->NPP_GetValue(NPPVpluginNeedsXEmbed, &xembed);
- DCHECK(err == NPERR_NO_ERROR);
- if (!xembed) {
- NOTIMPLEMENTED() << "Windowed plugin but without xembed.";
+ if (err != NPERR_NO_ERROR || !xembed) {
+ NOTIMPLEMENTED() << " windowed plugin but without xembed.";
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698