Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 195090: Address ExtensionApiTest.Tabs flakiness (Closed)

Created:
11 years, 3 months ago by rafaelw
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Address ExtensionApiTest.Tabs flakiness This addresses two problems. (1) relativeUrlTabsUpdate could fail because it was depending on testTabId getting set from relativeUrlTabsCreate, which may have happened out of order. I have refactored the callback blocking so additional blocks can be created with chrome.test.callbackAdded(). (2) tabs.update({url:}) is still failing intermitantly. This changes addeds valid html files in the extension which can be navitation targets (previously, non-existent urls had been used), in the hopes that the random failures had to do with load errors. BUG=20828 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26258

Patch Set 1 #

Patch Set 2 : pre commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -49 lines) Patch
M chrome/browser/extensions/extension_tabs_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/renderer_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extension_apitest.js View 4 chunks +12 lines, -13 lines 0 comments Download
A chrome/test/data/extensions/api_test/tabs/a.html View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/tabs/b.html View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/tabs/c.html View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/tabs/d.html View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/tabs/e.html View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/tabs/f.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/tabs/test.js View 10 chunks +41 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rafaelw
11 years, 3 months ago (2009-09-15 18:34:52 UTC) #1
asargent_no_longer_on_chrome
LGTM
11 years, 3 months ago (2009-09-15 19:16:10 UTC) #2
Erik does not do reviews
11 years, 3 months ago (2009-09-15 19:44:35 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698