Flakiness dashboard changes:...

Flakiness dashboard changes:
-Add a view of skipped tests for that platform
-Don't mark tests that timeout as needing a SLOW modifier.
-Show date and webkit/chrome blamelists when you click on results
-Show a line for when a webkit merge happens.

[arv (Not doing code reviews), 2009-09-14 23:42:04]

http://codereview.chromium.org/195081/diff/1/2
File webkit/tools/layout_tests/flakiness_dashboard.html (right):

http://codereview.chromium.org/195081/diff/1/2#newcode995
Line 995: html +=  '<h3>' +
Too many spaces

http://codereview.chromium.org/195081/diff/1/2#newcode1364
Line 1364: 
It seems cleaner if you do:

var popup = $(...);
if (!popup) {
  popup = createElement
  ...
}
...

http://codereview.chromium.org/195081/diff/1/2#newcode1382
Line 1382: window.onmousedown = function(e) {
document.onmousedown or document.addEventListener

http://codereview.chromium.org/195081/diff/1/2#newcode1386
Line 1386: !(popup.compareDocumentPosition(e.target) & 16)) {
webkit has Element.prototype.contains which is a lot cleaner than
compareDocumentPosition

[ojan, 2009-09-15 00:41:18]

http://codereview.chromium.org/195081/diff/1/2
File webkit/tools/layout_tests/flakiness_dashboard.html (right):

http://codereview.chromium.org/195081/diff/1/2#newcode995
Line 995: html +=  '<h3>' +
On 2009/09/14 23:42:04, arv wrote:
> Too many spaces

Done.

http://codereview.chromium.org/195081/diff/1/2#newcode1364
Line 1364: 
On 2009/09/14 23:42:04, arv wrote:
> It seems cleaner if you do:
> 
> var popup = $(...);
> if (!popup) {
>   popup = createElement
>   ...
> }
> ...

Done.

http://codereview.chromium.org/195081/diff/1/2#newcode1382
Line 1382: window.onmousedown = function(e) {
On 2009/09/14 23:42:04, arv wrote:
> document.onmousedown or document.addEventListener

Done. What's the difference?

http://codereview.chromium.org/195081/diff/1/2#newcode1386
Line 1386: !(popup.compareDocumentPosition(e.target) & 16)) {
On 2009/09/14 23:42:04, arv wrote:
> webkit has Element.prototype.contains which is a lot cleaner than
> compareDocumentPosition

I'd like for the dashboard to at least be functional in FF, even if it looks
slightly less good. Make sense?

[arv (Not doing code reviews), 2009-09-15 16:51:59]

lg

http://codereview.chromium.org/195081/diff/1/2
File webkit/tools/layout_tests/flakiness_dashboard.html (right):

http://codereview.chromium.org/195081/diff/1/2#newcode1382
Line 1382: window.onmousedown = function(e) {
On 2009/09/15 00:41:18, ojan wrote:
> On 2009/09/14 23:42:04, arv wrote:
> > document.onmousedown or document.addEventListener
> 
> Done. What's the difference?

window is window, document is document :-)

window is not part of the DOM tree and in theory events do not propagate to it.

http://codereview.chromium.org/195081/diff/1/2#newcode1386
Line 1386: !(popup.compareDocumentPosition(e.target) & 16)) {
On 2009/09/15 00:41:18, ojan wrote:
> On 2009/09/14 23:42:04, arv wrote:
> > webkit has Element.prototype.contains which is a lot cleaner than
> > compareDocumentPosition
> 
> I'd like for the dashboard to at least be functional in FF, even if it looks
> slightly less good. Make sense?

OK