Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 195061: Control profiling/debugger support from build script (Closed)

Created:
11 years, 3 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Control profiling/debugger support from build script. The SCons build now has the options profilingsupport and debuggersupport for controlling the setting of the defines ENABLE_LOGGIGN_AND_PROFILING and ENABLE_DEBUGGER_SUPPORT. By default both are set to true. The changes to the XCode project have not been tested. Committed: http://code.google.com/p/v8/source/detail?r=2875

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -19 lines) Patch
M SConstruct View 1 5 chunks +21 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/v8.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/x64/cfg-x64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/codegen-x64.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/v8.xcodeproj/project.pbxproj View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/visual_studio/common.vsprops View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 3 months ago (2009-09-11 09:43:52 UTC) #1
Christian Plesner Hansen
Lgtm!
11 years, 3 months ago (2009-09-11 10:55:44 UTC) #2
Erik Corry
11 years, 3 months ago (2009-09-11 12:25:50 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698