Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 195054: Supressing the referrer header in the automation url request job when going f... (Closed)

Created:
11 years, 3 months ago by tommi (sloooow) - chröme
Modified:
9 years, 7 months ago
Reviewers:
robertshield
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google), Paweł Hajdan Jr.
Visibility:
Public.

Description

Supressing the referrer header in the automation url request job when going from a secure to non-secure URL. Also calling OnSSLCertificateError in case of certificate errors. TEST=Run automation tests. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25867

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M chrome/browser/automation/url_request_automation_job.cc View 1 2 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tommi (sloooow) - chröme
11 years, 3 months ago (2009-09-10 15:31:24 UTC) #1
robertshield
LGTM http://codereview.chromium.org/195054/diff/1/2 File chrome/browser/automation/url_request_automation_job.cc (right): http://codereview.chromium.org/195054/diff/1/2#newcode326 Line 326: request_->delegate()->OnSSLCertificateError(request_, status.os_error(), xnay on the ULLNay ertificatecay
11 years, 3 months ago (2009-09-10 15:39:35 UTC) #2
tommi (sloooow) - chröme
11 years, 3 months ago (2009-09-10 15:47:39 UTC) #3
Iway ustjay ommentedcay outway ethay allcay otay OnSSLCertificateErrorway orfay
ownay andway eftlay away odotay orfay yselfmay.  Isthay ouldshay ebay andledhay
(andway ymay 
eststay owedshay atthay itway asway orkingway) utbay ere'sthay alwaysway away
ancechay atthay omeonesay illway expectway away onnay-Ullnay ointerpay.

ok... I realize that's a pain in the neck to read... so:

I just commented out the call to OnSSLCertificateError for now and left a todo
for myself.  This should be handled (and my tests showed that it was working)
but there's always a chance that someone will expect a non-Null pointer.

Powered by Google App Engine
This is Rietveld 408576698