Simplify the gtk location bar padding and make it more consistent.

Simplify the gtk location bar padding and make it more consistent.

Sets the container border and box padding values, so that each widget doesn't need an alignment to pad itself.

With this the horizontal padding is almost the same as windows (in a few cases we have 1 more pixel between elements.)
The vertical padding should be unchanged.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25831

[mattm, 2009-09-09 23:57:13]

Examples:

http://www/~mattm/no_crawl/chrome/location_bar_padding/comparison1.png
http://www/~mattm/no_crawl/chrome/location_bar_padding/comparison2.png

(note: the middle image also includes page actions, which aren't part of this
code review.  Also, in comparison2 the EV text isn't drawn when you start
inputting text, which is a change in trunk, not due to this CL.)

[Elliot Glaysher, 2009-09-10 01:13:09]

LGTM:

http://codereview.chromium.org/195048/diff/1/2
File chrome/browser/gtk/location_bar_view_gtk.cc (right):

http://codereview.chromium.org/195048/diff/1/2#newcode160
Line 160: // keyword text with a border, background color, and padding around
the text.
Comment no longer applicable now that alignment gone?

[mattm, 2009-09-10 01:23:03]

On 2009/09/10 01:13:09, Elliot Glaysher wrote:
> LGTM:
> 
> http://codereview.chromium.org/195048/diff/1/2
> File chrome/browser/gtk/location_bar_view_gtk.cc (right):
> 
> http://codereview.chromium.org/195048/diff/1/2#newcode160
> Line 160: // keyword text with a border, background color, and padding around
> the text.
> Comment no longer applicable now that alignment gone?

I don't know, I assumed the comment was (mostly) talking about what
gtk_util::CreateGtkBorderBin does, though it's a bit weird to talk about
implementation details of a library function defined elsewhere.  I simplified
the comment.