Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: webkit/glue/plugins/plugin_list_linux.cc

Issue 195044: linux: search Chrome-specific plugin directories before Mozilla (Closed)
Patch Set: with comment Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/plugins/plugin_list_linux.cc
diff --git a/webkit/glue/plugins/plugin_list_linux.cc b/webkit/glue/plugins/plugin_list_linux.cc
index 41c8c438df67b84bfff5158554def3b91ea0e551..b09d30c854560bcb9d8e91eddb9906a6caca5b3d 100644
--- a/webkit/glue/plugins/plugin_list_linux.cc
+++ b/webkit/glue/plugins/plugin_list_linux.cc
@@ -50,6 +50,19 @@ void PluginList::PlatformInit() {
}
void PluginList::GetPluginDirectories(std::vector<FilePath>* plugin_dirs) {
+ // See http://groups.google.com/group/chromium-dev/browse_thread/thread/7a70e5fcbac786a9
+ // for discussion.
+ // We first consult Chrome-specific dirs, then fall back on the logic
+ // Mozilla uses.
+
+ // TODO(evanm): maybe consult our own plugins dir, like
+ // ~/.config/chromium/Plugins?
+
+ // The Chrome binary dir + "plugins/".
+ FilePath dir;
+ PathService::Get(base::DIR_EXE, &dir);
+ plugin_dirs->push_back(dir.Append("plugins"));
+
// Mozilla code to reference:
// http://mxr.mozilla.org/firefox/ident?i=NS_APP_PLUGINS_DIR_LIST
// and tens of accompanying files (mxr is very helpful).
@@ -70,15 +83,8 @@ void PluginList::GetPluginDirectories(std::vector<FilePath>* plugin_dirs) {
const char* home = getenv("HOME");
if (home)
plugin_dirs->push_back(FilePath(home).Append(".mozilla/plugins"));
- // TODO(evanm): maybe consult our own plugins dir, like
- // ~/.config/chromium/Plugins?
-
- // 3) NS_APP_PLUGINS_DIR: the binary dir + "plugins/".
- FilePath dir;
- PathService::Get(base::DIR_EXE, &dir);
- plugin_dirs->push_back(dir.Append("plugins"));
- // 4) NS_SYSTEM_PLUGINS_DIR:
+ // 3) NS_SYSTEM_PLUGINS_DIR:
// This varies across different versions of Firefox, so check 'em all.
plugin_dirs->push_back(FilePath("/usr/lib/mozilla/plugins"));
plugin_dirs->push_back(FilePath("/usr/lib/firefox/plugins"));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698