Issue 195023: Add scripts to automatically build installer and disk image in GYP build. ...

Issue 195023: Add scripts to automatically build installer and disk image in GYP build. ... (Closed)

Created:
11 years, 3 months ago by maf

Modified:
9 years, 7 months ago

Reviewers:
Greg Spencer

CC:
o3d-review_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/o3d/

Visibility:
Public.

Description

Add scripts to automatically build installer and disk image in GYP build. Fix compile error in serializer.cc Don't force rebuild of idl files. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25642

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Total comments: 8

Patch Set 10 : '' #

Patch Set 11 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+178 lines, -2 lines)			Patch
M	installer/installer.gyp	View	6 7 8 9 10	1 chunk	+1 line, -1 line	0 comments	Download
M	installer/mac/installer.gyp	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+25 lines, -0 lines	0 comments	Download
A	installer/mac/make_disk_image.sh	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+81 lines, -0 lines	0 comments	Download
A	installer/mac/make_installer.sh	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+71 lines, -0 lines	0 comments	Download
M	plugin/idl/idl.gyp	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Greg Spencer

LGTM, modulo the stuff below. http://codereview.chromium.org/195023/diff/3012/3014 File installer/mac/make_disk_image.sh (right): http://codereview.chromium.org/195023/diff/3012/3014#newcode1 Line 1: #!/bin/bash Should add ...

11 years, 3 months ago (2009-09-08 18:00:56 UTC) #5

maf

11 years, 3 months ago (2009-09-17 01:25:51 UTC) #6

All fixed and checked in last week.

http://codereview.chromium.org/195023/diff/3012/3014
File installer/mac/make_disk_image.sh (right):

http://codereview.chromium.org/195023/diff/3012/3014#newcode1
Line 1: #!/bin/bash
On 2009/09/08 18:00:56, Greg Spencer wrote:
> Should add copyright string here.

Done.

http://codereview.chromium.org/195023/diff/3012/3015
File installer/mac/make_installer.sh (right):

http://codereview.chromium.org/195023/diff/3012/3015#newcode2
Line 2: 
On 2009/09/08 18:00:56, Greg Spencer wrote:
> Copyright.

Done.

http://codereview.chromium.org/195023/diff/3012/3017
File serializer/cross/serializer.cc (right):

http://codereview.chromium.org/195023/diff/3012/3017#newcode327
Line 327: int i_a_size =  influences_array.size();
On 2009/09/08 18:00:56, Greg Spencer wrote:
> Why not use Skin::InfluencesArray::size_type here instead?

File reverted (you'd already fixed in another checkin).

http://codereview.chromium.org/195023/diff/3012/3017#newcode331
Line 331: int i_size = influences.size();
On 2009/09/08 18:00:56, Greg Spencer wrote:
> Why not use Skin::Influences::size_type here instead?

File reverted (you'd already fixed in another checkin).

Expand Messages | Collapse Messages