Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 195014: X64 RegExp - fix RegExp on WIN64. (Closed)

Created:
11 years, 3 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Søren Thygesen Gjesse, sgjesse
CC:
v8-dev
Visibility:
Public.

Description

X64 RegExp - fix RegExp on WIN64. Use the correct ifdef to detect Win64 (_WIN64, not __MSVC__).

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M src/runtime.cc View 2 chunks +1 line, -2 lines 1 comment Download
M src/x64/regexp-macro-assembler-x64.h View 2 chunks +4 lines, -2 lines 0 comments Download
src/x64/regexp-macro-assembler-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
Small review.
11 years, 3 months ago (2009-09-04 10:48:15 UTC) #1
Lasse Reichstein
http://codereview.chromium.org/195014/diff/1/2 File src/runtime.cc (left): http://codereview.chromium.org/195014/diff/1/2#oldcode1 Line 1: // Copyright 2006-2009 the V8 project authors. All ...
11 years, 3 months ago (2009-09-04 10:52:14 UTC) #2
Søren Thygesen Gjesse
11 years, 3 months ago (2009-09-04 10:54:10 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698