Add a Mac-specifc snapshot build archive bisecting tool.

Add a Mac-specifc snapshot build archive bisecting tool.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25384

[Evan Martin, 2009-09-03 19:21:19]

bunch of style comments

http://codereview.chromium.org/195006/diff/2001/2002
File build/build-bisect.py (right):

http://codereview.chromium.org/195006/diff/2001/2002#newcode1
Line 1: #!/usr/bin/env python2.5
/usr/bin/python2.5?

http://codereview.chromium.org/195006/diff/2001/2002#newcode5
Line 5: 
Can you stick a file description in this?
See e.g. webkit/tools/layout_tests/rebaseline.py for the format.
Maybe mention it's mac-specific for now but that it can be made cross-platform.

http://codereview.chromium.org/195006/diff/2001/2002#newcode37
Line 37: # Parses the HTML directory listing into a list of revision numbers.
Function descriptions go in as the first line of functions (docstring style,
reference the other python script mentioned above)

http://codereview.chromium.org/195006/diff/2001/2002#newcode38
Line 38: def parseDirectoryIndex(url):
StudlyCaps for functions here and elsewhere:  ParseDirectoryIndex

http://codereview.chromium.org/195006/diff/2001/2002#newcode48
Line 48: revlist = map(lambda r: int(r), revlist)
map(int, revlist)

http://codereview.chromium.org/195006/diff/2001/2002#newcode55
Line 55: # Clear anything that's currenlty there.
typo: currently

http://codereview.chromium.org/195006/diff/2001/2002#newcode67
Line 67: print("Could not retrieve the download. Sorry.")
maybe print the url?

http://codereview.chromium.org/195006/diff/2001/2002#newcode80
Line 80: if (check == "g" or check  == "b"):
no parens needed in if statements

http://codereview.chromium.org/195006/diff/2001/2002#newcode94
Line 94: badRev = raw_input("Bad revision [HEAD:%d]: " % latest)
variable name style: "bad_rev", here and elsewhere

http://codereview.chromium.org/195006/diff/2001/2002#newcode113
Line 113: if (goodRev == 0):
no parens on if statements, later while statemetn

[Robert Sesek, 2009-09-03 19:44:22]

On 2009/09/03 19:21:19, Evan Martin wrote:
> bunch of style comments

Yes, sorry. This was a personal script so it didn't use Google guidelines. All
fixed (I hope).

[Evan Martin, 2009-09-03 20:18:49]

LGTM, thanks for fixing it!

http://codereview.chromium.org/195006/diff/4001/4002
File build/build-bisect.py (right):

http://codereview.chromium.org/195006/diff/4001/4002#newcode155
Line 155: print("You are probably looking for build %d." % revlist[bad])
Maybe point out that this build is the earliest *bad* one, rather than the last
good one?

[Mark Mentovai, 2009-09-03 20:31:28]

This is a cute idea.