Issue 19486: Lint cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19486: Lint cleanup. (Closed)

Created:
11 years, 10 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a bunch of lint complaints in preparation to land issue 19046. Mostly formatting changes, i.e. CRLF, space at end of line. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8933

Patch Set 1 #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+380 lines, -381 lines)			Patch
M	chrome/browser/renderer_host/backing_store.h	View	1 chunk	+130 lines, -130 lines	1 comment	Download
M	chrome/browser/renderer_host/backing_store.cc	View	1 chunk	+108 lines, -109 lines	0 comments	Download
M	chrome/browser/renderer_host/backing_store_win.cc	View	1 chunk	+122 lines, -122 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/render_messages.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/renderer/render_widget.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	skia/ext/platform_canvas_mac.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	skia/ext/platform_canvas_mac.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	skia/ext/platform_canvas_win.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	skia/ext/platform_canvas_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

LGTM http://codereview.chromium.org/19486/diff/1/6 File chrome/browser/renderer_host/backing_store.h (right): http://codereview.chromium.org/19486/diff/1/6#newcode9 Line 9: #include <windows.h> This actually needs to be ...

11 years, 10 months ago (2009-01-30 00:26:22 UTC) #2

Lei Zhang

11 years, 10 months ago (2009-01-30 00:33:45 UTC) #3

On 2009/01/30 00:26:22, brettw wrote:
> LGTM
> 
> http://codereview.chromium.org/19486/diff/1/6
> File chrome/browser/renderer_host/backing_store.h (right):
> 
> http://codereview.chromium.org/19486/diff/1/6#newcode9
> Line 9: #include <windows.h>
> This actually needs to be below to after build_config.h
> I would just leave it where it is.

Ok, I put it back. Committing.

Expand Messages | Collapse Messages