Add logging to undersand exactly where CreateDirectory() is failing for users...

base/file_util_win.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 
 #include <windows.h>
 #include <propvarutil.h>
 #include <shellapi.h>
 #include <shlobj.h>
@@ skipping 521 matching lines @@
 
 bool CreateNewTempDirectory(const FilePath::StringType& prefix,
                             FilePath* new_temp_path) {
   FilePath system_temp_dir;
   if (!GetTempDir(&system_temp_dir))
     return false;
 
   return CreateTemporaryDirInDir(system_temp_dir, prefix, new_temp_path);
 }
 
+// TODO(skerner): Extra logging has been added to understand crbug/35198 .
+// Remove it once we get a log from a user who can reproduce the issue.
 bool CreateDirectory(const FilePath& full_path) {
+  LOG(INFO) << "Enter CreateDirectory: full_path = " << full_path.value();
   // If the path exists, we've succeeded if it's a directory, failed otherwise.
   const wchar_t* full_path_str = full_path.value().c_str();
   DWORD fileattr = ::GetFileAttributes(full_path_str);
+  LOG(INFO) << "::GetFileAttributes() returned " << fileattr;
   if (fileattr != INVALID_FILE_ATTRIBUTES) {
     if ((fileattr & FILE_ATTRIBUTE_DIRECTORY) != 0) {
-      DLOG(INFO) << "CreateDirectory(" << full_path_str << "), " <<
+      LOG(INFO) << "CreateDirectory(" << full_path_str << "), " <<
           "directory already exists.";
       return true;
     } else {
       LOG(WARNING) << "CreateDirectory(" << full_path_str << "), " <<
           "conflicts with existing file.";
     }
   }
 
   // Invariant:  Path does not exist as file or directory.
 
   // Attempt to create the parent recursively.  This will immediately return
   // true if it already exists, otherwise will create all required parent
   // directories starting with the highest-level missing parent.
   FilePath parent_path(full_path.DirName());
   if (parent_path.value() == full_path.value()) {
+    LOG(INFO) << "Can't create directory: parent_path " <<
+        parent_path.value() << " should not equal full_path " <<
+        full_path.value();
     return false;
   }
   if (!CreateDirectory(parent_path)) {
-    DLOG(WARNING) << "Failed to create one of the parent directories.";
+    LOG(INFO) << "Failed to create one of the parent directories: " <<
+        parent_path.value();
     return false;
   }
 
+  LOG(INFO) << "About to call ::CreateDirectory() with full_path_str = " <<
+      full_path_str;
   if (!::CreateDirectory(full_path_str, NULL)) {
     DWORD error_code = ::GetLastError();
     if (error_code == ERROR_ALREADY_EXISTS && DirectoryExists(full_path)) {
       // This error code doesn't indicate whether we were racing with someone
       // creating the same directory, or a file with the same path, therefore
       // we check.
+      LOG(INFO) << "Race condition? Directory already exists: " <<
+          full_path.value();
       return true;
     } else {
       LOG(WARNING) << "Failed to create directory " << full_path_str <<
           ", le=" << error_code;
       return false;
     }
   } else {
+    LOG(INFO) << "::CreateDirectory() worked.";
     return true;
   }
 }
 
 bool GetFileInfo(const FilePath& file_path, FileInfo* results) {
   WIN32_FILE_ATTRIBUTE_DATA attr;
   if (!GetFileAttributesEx(file_path.ToWStringHack().c_str(),
                            GetFileExInfoStandard, &attr)) {
     return false;
   }
@@ skipping 283 matching lines @@
 }
 
 bool HasFileBeenModifiedSince(const FileEnumerator::FindInfo& find_info,
                               const base::Time& cutoff_time) {
   long result = CompareFileTime(&find_info.ftLastWriteTime,
                                 &cutoff_time.ToFileTime());
   return result == 1 || result == 0;
 }
 
 }  // namespace file_util