Make test server to store files by sending POST /writefile/<filename> HTTP re...

Make test server to store files by sending POST /writefile/<filename> HTTP request.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8965

[Erik does not do reviews, 2009-01-29 23:42:09]

http://codereview.chromium.org/19476/diff/1/2
File net/tools/testserver/testserver.py (right):

http://codereview.chromium.org/19476/diff/1/2#newcode407
Line 407: the data_dir. Sub-directories are not supported."""
I'm a little concerned by this.  Do you intend to support overwriting existing
URLs in the document root?  How does the data that gets written by tests get
cleaned up afterwards?  If the intent is to just be able to upload data that you
can then download again, maybe there should be a scratch directory that's
destroyed at startup/shutdown to ensure it's clean for the tests and indpendent
of the normal read-only content.

http://codereview.chromium.org/19476/diff/1/2#newcode416
Line 416: re.sub('[^a-zA-Z0-9_.-]+', '', file_name)
this looks like it would allow "." or ".."

[stoyan, 2009-01-30 01:15:18]

http://codereview.chromium.org/19476/diff/1/2
File net/tools/testserver/testserver.py (right):

http://codereview.chromium.org/19476/diff/1/2#newcode407
Line 407: the data_dir. Sub-directories are not supported."""
On 2009/01/29 23:42:09, Erik Kay wrote:
> I'm a little concerned by this.  Do you intend to support overwriting existing
> URLs in the document root? 

No.

> How does the data that gets written by tests get
> cleaned up afterwards?  

The intention is:
1) Start the web server from the unittest.
2) Start the browser opening a specific page with some JScript code inside.
3) Wait predefined period of time, kill the server and inspect the content of
the files uploaded by JScript code. Reading files directly from filesystem in
the unittest and compare with expected content. Delete these files from the
unittest.
For now reading these uploaded files back through the server is not required.


> If the intent is to just be able to upload data that you
> can then download again, maybe there should be a scratch directory that's
> destroyed at startup/shutdown to ensure it's clean for the tests and
indpendent
> of the normal read-only content.

Added creation of 'dump' directory cleaned at startup.

http://codereview.chromium.org/19476/diff/1/2#newcode416
Line 416: re.sub('[^a-zA-Z0-9_.-]+', '', file_name)
On 2009/01/29 23:42:09, Erik Kay wrote:
> this looks like it would allow "." or ".."

Done.

[Erik does not do reviews, 2009-01-30 01:29:38]

LGTM

thanks for the detailed explanation