Issue 1944001: Port inline swapping of elements for the sort function in array.js...

Issue 1944001: Port inline swapping of elements for the sort function in array.js... (Closed)

Created:
10 years, 7 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Port inline swapping of elements for the sort function in array.js from ia32 to arm. Original change: http://codereview.chromium.org/1709008 Committed: http://code.google.com/p/v8/source/detail?r=4575

Patch Set 3 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+220 lines, -27 lines)			Patch
M	src/arm/codegen-arm.h	View	1 2	1 chunk	+37 lines, -0 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	1 2	3 chunks	+98 lines, -2 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 2	2 chunks	+43 lines, -18 lines	0 comments	Download
M	src/ia32/codegen-ia32.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1 2	2 chunks	+9 lines, -1 line	0 comments	Download
M	src/x64/codegen-x64.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 2	2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/1944001/diff/9001/10006 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/1944001/diff/9001/10006#newcode4400 src/arm/codegen-arm.cc:4400: // Swap elements. Register tmp3 = object; object ...

10 years, 7 months ago (2010-05-04 10:25:36 UTC) #2

Mads Ager (chromium)

10 years, 7 months ago (2010-05-04 11:06:34 UTC) #3

http://codereview.chromium.org/1944001/diff/9001/10006
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/1944001/diff/9001/10006#newcode4400
src/arm/codegen-arm.cc:4400: // Swap elements.
On 2010/05/04 10:25:36, Søren Gjesse wrote:
> Register tmp3 = object; object = no_reg?

Done.

http://codereview.chromium.org/1944001/diff/9001/10007
File src/arm/codegen-arm.h (right):

http://codereview.chromium.org/1944001/diff/9001/10007#newcode882
src/arm/codegen-arm.h:882: // Minor key encoding in 12 bits of three registers
(object, address and
On 2010/05/04 10:25:36, Søren Gjesse wrote:
> ... bits of three registers ... -> ... bits. 4 bits for each of the three
> registers ...

Done on all platforms.

http://codereview.chromium.org/1944001/diff/9001/10008
File src/arm/macro-assembler-arm.cc (right):

http://codereview.chromium.org/1944001/diff/9001/10008#newcode237
src/arm/macro-assembler-arm.cc:237: Register scratch) {
On 2010/05/04 10:25:36, Søren Gjesse wrote:
> Maybe add an assert for InNewSpace guarded by the --debug-code flag. Relevant
on
> all three platforms.

Done on all platforms.

Expand Messages | Collapse Messages