Issue 194118: Add a new flag to the installer to prevent registering for a Google Update la...

Issue 194118: Add a new flag to the installer to prevent registering for a Google Update la... (Closed)

Created:
11 years, 3 months ago by robertshield

Modified:
9 years, 6 months ago

Reviewers:
kuchhal

CC:
chromium-reviews_googlegroups.com, kuchhal, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add a new flag to the installer to prevent registering for a Google Update launch. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26255

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -1 line)			Patch
M	chrome/installer/setup/setup_main.cc	View	1	1 chunk	+7 lines, -1 line	0 comments	Download
M	chrome/installer/setup/setup_util.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/installer/util/master_preferences.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/installer/util/master_preferences.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/installer/util/master_preferences_unittest.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/installer/util/util_constants.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/installer/util/util_constants.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kuchhal

lgtm. http://codereview.chromium.org/194118/diff/1/3 File chrome/installer/setup/setup_main.cc (right): http://codereview.chromium.org/194118/diff/1/3#newcode275 Line 275: !installer_util::GetDistroBooleanPreference(prefs, indent by two more space http://codereview.chromium.org/194118/diff/1/2 ...

11 years, 3 months ago (2009-09-15 19:05:45 UTC) #2

robertshield

11 years, 3 months ago (2009-09-15 19:21:13 UTC) #3

Thanks!

http://codereview.chromium.org/194118/diff/1/3
File chrome/installer/setup/setup_main.cc (right):

http://codereview.chromium.org/194118/diff/1/3#newcode275
Line 275: !installer_util::GetDistroBooleanPreference(prefs,
On 2009/09/15 19:05:45, kuchhal wrote:
> indent by two more space

Done.

http://codereview.chromium.org/194118/diff/1/2
File chrome/installer/setup/setup_util.cc (right):

http://codereview.chromium.org/194118/diff/1/2#newcode63
Line 63: }
On 2009/09/15 19:05:45, kuchhal wrote:
> you can remove {} to use same style as other if statements here.

Done.

http://codereview.chromium.org/194118/diff/1/5
File chrome/installer/util/master_preferences_unittest.cc (right):

http://codereview.chromium.org/194118/diff/1/5#newcode143
Line 143: installer_util::master_preferences::kDoNotRegisterForUpdateLaunch));
On 2009/09/15 19:05:45, kuchhal wrote:
> indent by two more space.

Done.

Expand Messages | Collapse Messages