Issue 194116: Give a document icon to Chromium for file types it can view when preview is t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 194116: Give a document icon to Chromium for file types it can view when preview is t... (Closed)

Created:
11 years, 3 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Give a document icon to Chromium for file types it can view when preview is turned off. BUG=19763 TEST=per bug. This might not appear to work given how LaunchServices caches and registers applications. You may need to test on a totally clean machine. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26248

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -2 lines)			Patch
M	chrome/app/app-Info.plist	View	6 chunks	+12 lines, -0 lines	1 comment	Download
A	chrome/app/theme/chromium/document.icns	View	Binary file		0 comments	Download
M	chrome/chrome.gyp	View	2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LG otherwise http://codereview.chromium.org/194116/diff/1006/7 File chrome/app/app-Info.plist (right): http://codereview.chromium.org/194116/diff/1006/7#newcode12 Line 12: <key>CFBundleTypeIconFile</key> Anal: keep dict keys sorted, ...

11 years, 3 months ago (2009-09-15 18:01:49 UTC) #2

Mark Mentovai

11 years, 3 months ago (2009-09-15 18:02:32 UTC) #3

If there's a followup CL for the Chrome icon, can that CL land first?

I generally build with Chrome branding for various reasons, and this will break
me if it lands without a Chrome icon.

Expand Messages | Collapse Messages