Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: chrome/browser/views/location_bar_view.h

Issue 194110: Convert the AutocompletePopupPositioner into a BubblePositioner in preparatio... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/views/location_bar_view.h
===================================================================
--- chrome/browser/views/location_bar_view.h (revision 26251)
+++ chrome/browser/views/location_bar_view.h (working copy)
@@ -27,7 +27,7 @@
#include "chrome/browser/autocomplete/autocomplete_edit_view_gtk.h"
#endif
-class AutocompletePopupPositioner;
+class BubblePositioner;
class CommandUpdater;
class GURL;
class PageAction;
@@ -73,7 +73,7 @@
ToolbarModel* model,
Delegate* delegate,
bool popup_window_mode,
- AutocompletePopupPositioner* popup_positioner);
+ const BubblePositioner* bubble_positioner);
virtual ~LocationBarView();
void Init();
@@ -339,9 +339,9 @@
class PageActionImageView : public LocationBarImageView,
public ImageLoadingTracker::Observer {
public:
- PageActionImageView(
- LocationBarView* owner, Profile* profile,
- const PageAction* page_action);
+ PageActionImageView(LocationBarView* owner,
+ Profile* profile,
+ const PageAction* page_action);
virtual ~PageActionImageView();
// Overridden from view for the mouse hovering.
@@ -518,8 +518,8 @@
// Used schedule a task for the first run info bubble.
ScopedRunnableMethodFactory<LocationBarView> first_run_bubble_;
- // The positioner that places the autocomplete popup.
- AutocompletePopupPositioner* popup_positioner_;
+ // The positioner that places the omnibox and info bubbles.
+ const BubblePositioner* bubble_positioner_;
// Storage of string needed for accessibility.
std::wstring accessible_name_;

Powered by Google App Engine
This is Rietveld 408576698