Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1617)

Unified Diff: chrome/renderer/notification_provider.cc

Issue 194108: adds DesktopNotificationService to Profile (Closed)
Patch Set: more feedback Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/notification_provider.cc
diff --git a/chrome/renderer/notification_provider.cc b/chrome/renderer/notification_provider.cc
index f6baba8f89e31ea95235a768da1be861e8cd32c6..309ad207b173cd27a98a16a21946fd125588530a 100644
--- a/chrome/renderer/notification_provider.cc
+++ b/chrome/renderer/notification_provider.cc
@@ -47,8 +47,8 @@ void NotificationProvider::objectDestroyed(
WebNotificationPresenter::Permission NotificationProvider::checkPermission(
const WebString& origin) {
int permission;
- Send(new ViewHostMsg_CheckNotificationPermission(view_->routing_id(), origin,
- &permission));
+ Send(new ViewHostMsg_CheckNotificationPermission(view_->routing_id(),
+ GURL(origin), &permission));
return static_cast<WebNotificationPresenter::Permission>(permission);
}
@@ -57,7 +57,7 @@ void NotificationProvider::requestPermission(
int id = manager_.RegisterPermissionRequest(callback);
Send(new ViewHostMsg_RequestNotificationPermission(view_->routing_id(),
- origin, id));
+ GURL(origin), id));
}
bool NotificationProvider::ShowHTML(const WebNotification& notification,

Powered by Google App Engine
This is Rietveld 408576698