Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: PRESUBMIT.py

Issue 1941004: Fix a bug in PRESUBMIT.py because of default argument ordering. (Closed)
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index bdbbd78281670b11f168df6c784fafff3efaa818..383819e2320ae3f8852a48b511a0d7f7cfc6d4eb 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -42,21 +42,21 @@ def _CommonChecks(input_api, output_api):
text_files = lambda x: input_api.FilterSourceFile(x, black_list=black_list,
white_list=white_list)
results.extend(input_api.canned_checks.CheckLongLines(
- input_api, output_api, sources))
+ input_api, output_api, source_file_filter=sources))
results.extend(input_api.canned_checks.CheckChangeHasNoTabs(
- input_api, output_api, sources))
+ input_api, output_api, source_file_filter=sources))
results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
- input_api, output_api, sources))
+ input_api, output_api, source_file_filter=sources))
results.extend(input_api.canned_checks.CheckChangeHasBugField(
input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeHasTestField(
input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeSvnEolStyle(
- input_api, output_api, text_files))
+ input_api, output_api, source_file_filter=text_files))
results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
input_api, output_api))
results.extend(input_api.canned_checks.CheckLicense(
- input_api, output_api, _LICENSE_HEADER, sources))
+ input_api, output_api, _LICENSE_HEADER, source_file_filter=sources))
return results
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698