Issue 19407: Make purify happy by fixing memory leak that shows up during shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19407: Make purify happy by fixing memory leak that shows up during shutdown. (Closed)

Created:
11 years, 11 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), jar (doing other things)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make purify happy by fixing memory leak that shows up during shutdown. BUG=6528

Patch Set 1 #

Total comments: 1

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/browser/metrics/metrics_service.cc	View		1 chunk	+8 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kuchhal

This is one possible fix to make Purify happy for ui tests. The problem is ...

11 years, 11 months ago (2009-01-28 00:43:38 UTC) #1

jar (doing other things)

I'm not completely clear on the scenario where this fires... but the code is safe, ...

11 years, 11 months ago (2009-01-28 01:11:19 UTC) #2

darin (slow to review)

11 years, 11 months ago (2009-01-28 09:18:27 UTC) #3

http://codereview.chromium.org/19407/diff/1/2
File chrome/browser/metrics/metrics_service.cc (right):

http://codereview.chromium.org/19407/diff/1/2#newcode352
Line 352: if (pending_log_) {
nit: there's no need to null-check a pointer before calling delete on it. 
"delete NULL" is a no-op.

Expand Messages | Collapse Messages