Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 194068: Clear Browsing Data should not have a default button (Closed)

Created:
11 years, 3 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Application Menu:Clear Browsing Data… should not have Clear Browsing Data as the default action. Buttons with destructive actions should never be the default. This removes the return key equivalent from the Clear Browsing Data button. It also adds an escape key equivalent to the Cancel button, so that it will blink appropriately in response to both escape and command-period. BUG=21461 TEST=Look and try as above Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/nibs/ClearBrowsingData.xib View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
11 years, 3 months ago (2009-09-10 04:52:49 UTC) #1
pink (ping after 24hrs)
11 years, 3 months ago (2009-09-10 15:00:10 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698