net/url_request/url_request_ftp_job.cc - Issue 194057: Check in patch for pierre.lafayette, http://codereview.chromium.org/178059/sh...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_ftp_job.cc

Issue 194057: Check in patch for pierre.lafayette, http://codereview.chromium.org/178059/sh... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/url_request/url_request_ftp_job.cc

===================================================================

--- net/url_request/url_request_ftp_job.cc (revision 25619)

+++ net/url_request/url_request_ftp_job.cc (working copy)

@@ -62,8 +62,10 @@

DCHECK(scheme == "ftp");

+ int port = request->url().IntPort();

if (request->url().has_port() &&

- !net::IsPortAllowedByFtp(request->url().IntPort()))

+ !net::IsPortAllowedByFtp(port) && !net::IsPortAllowedByOverride(port))

return new URLRequestErrorJob(request, net::ERR_UNSAFE_PORT);

return new URLRequestFtpJob(request);

« no previous file with comments | « net/base/net_util_unittest.cc ('k') | net/url_request/url_request_http_job.h » ('j') | no next file with comments »