Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 194049: Implemented shared memory as an NPObject. (Closed)

Created:
11 years, 3 months ago by apatrick
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, Paweł Hajdan Jr.
Visibility:
Public.

Description

Implemented shared memory as an NPObject. Using NPObject method to expose mapping function rather than NPAPI change. Note that shared memory objects currently lose identity when they cross a process boundary. If an object is sent across a boundary and back, there are now two objects representing the same handle in a single process. This can be fixed. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25749

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+546 lines, -124 lines) Patch
M o3d/gpu_plugin/command_buffer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M o3d/gpu_plugin/command_buffer.cc View 2 chunks +15 lines, -11 lines 0 comments Download
M o3d/gpu_plugin/command_buffer_unittest.cc View 4 chunks +19 lines, -23 lines 0 comments Download
M o3d/gpu_plugin/gpu_plugin.gyp View 3 chunks +97 lines, -21 lines 0 comments Download
M o3d/gpu_plugin/gpu_plugin_object.h View 2 chunks +1 line, -2 lines 0 comments Download
M o3d/gpu_plugin/gpu_plugin_object.cc View 2 chunks +1 line, -6 lines 0 comments Download
M o3d/gpu_plugin/np_utils/np_browser.h View 2 chunks +0 lines, -11 lines 0 comments Download
M o3d/gpu_plugin/np_utils/np_browser.cc View 2 chunks +1 line, -21 lines 0 comments Download
M o3d/gpu_plugin/np_utils/np_browser_mock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M o3d/gpu_plugin/np_utils/np_browser_stub.h View 1 chunk +0 lines, -9 lines 0 comments Download
M o3d/gpu_plugin/np_utils/np_browser_stub.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M o3d/gpu_plugin/np_utils/np_object_mock.h View 1 chunk +1 line, -2 lines 0 comments Download
A o3d/gpu_plugin/np_utils/webkit_browser.h View 1 chunk +112 lines, -0 lines 0 comments Download
A o3d/gpu_plugin/system_services/shared_memory.h View 1 chunk +55 lines, -0 lines 0 comments Download
A o3d/gpu_plugin/system_services/shared_memory.cc View 1 chunk +65 lines, -0 lines 2 comments Download
A o3d/gpu_plugin/system_services/shared_memory_mock.h View 1 chunk +30 lines, -0 lines 0 comments Download
A o3d/gpu_plugin/system_services/shared_memory_public.h View 1 chunk +33 lines, -0 lines 1 comment Download
A o3d/gpu_plugin/system_services/shared_memory_unittest.cc View 1 chunk +112 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
apatrick
The browser code relating to this is in http://codereview.chromium.org/184022. I don't need that CL reviewed ...
11 years, 3 months ago (2009-09-09 00:06:43 UTC) #1
Ken Russell (Google)
LGTM http://codereview.chromium.org/194049/diff/1/5 File o3d/gpu_plugin/system_services/shared_memory.cc (right): http://codereview.chromium.org/194049/diff/1/5#newcode12 Line 12: shared_memory_(NULL) { Where are the NPObject fields ...
11 years, 3 months ago (2009-09-09 01:32:54 UTC) #2
apatrick
11 years, 3 months ago (2009-09-09 02:10:17 UTC) #3
http://codereview.chromium.org/194049/diff/1/5
File o3d/gpu_plugin/system_services/shared_memory.cc (right):

http://codereview.chromium.org/194049/diff/1/5#newcode12
Line 12: shared_memory_(NULL) {
Shared memory objects are created through NPN_CreateObject (or
WebKit::WebBindings::createObject), which initializes those fields.

Powered by Google App Engine
This is Rietveld 408576698