Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 194041: Making the focus remembering across tab switch work. (Closed)

Created:
11 years, 3 months ago by jcampan
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

This CL makes the focus remembered across tab switches for Chrome Linux with toolkit views. It also contains clean-ups and implementation of different minor focus related things. BUG=None TEST=Open several tabs. Focus the location bar for some tabs, the page for others. Make sure that when switching between tabs the focus is restored to the last focused place (location bar or page) for each tab. Also test that deactivating/reactivating the browser window still restores focus properly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26153

Patch Set 1 #

Patch Set 2 : Fixing minor nits. #

Patch Set 3 : Merging ToT #

Patch Set 4 : Mac build fix #

Patch Set 5 : Fix conflicts #

Patch Set 6 : Fix for conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -79 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.h View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.mm View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/browser_frame_gtk.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/views/frame/browser_frame_gtk.cc View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/views/location_bar_view.cc View 1 2 3 4 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/views/tab_contents/native_tab_contents_container_gtk.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc View 1 4 chunks +6 lines, -62 lines 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_gtk.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_gtk.cc View 1 2 3 chunks +50 lines, -3 lines 0 comments Download
M views/controls/native/native_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/native/native_view_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M views/controls/native/native_view_host_gtk.h View 2 chunks +8 lines, -0 lines 0 comments Download
M views/controls/native/native_view_host_gtk.cc View 6 chunks +28 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jcampan
11 years, 3 months ago (2009-09-08 18:12:12 UTC) #1
Ben Goodger (Google)
11 years, 3 months ago (2009-09-11 22:15:40 UTC) #2
OK

Powered by Google App Engine
This is Rietveld 408576698