Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 194039: Use local cpplint.py if it exists (Closed)

Created:
11 years, 3 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Use local cpplint.py if it exists. If there is a local cpplint.py in the tools directory use this instead of any cpplint in the path. This makes it possible to run presubmit checks on Windows by downloading cpplint.py from http://code.google.com/p/google-styleguide/. Committed: http://code.google.com/p/v8/source/detail?r=2874

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M tools/presubmit.py View 4 chunks +7 lines, -4 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 3 months ago (2009-09-08 07:31:02 UTC) #1
Christian Plesner Hansen
Lgtm http://codereview.chromium.org/194039/diff/1/2 File tools/presubmit.py (right): http://codereview.chromium.org/194039/diff/1/2#newcode153 Line 153: command = ['python', local_cpplint, '--filter', filt] + ...
11 years, 3 months ago (2009-09-08 07:48:58 UTC) #2
Søren Thygesen Gjesse
11 years, 3 months ago (2009-09-11 12:30:53 UTC) #3
http://codereview.chromium.org/194039/diff/1/2
File tools/presubmit.py (right):

http://codereview.chromium.org/194039/diff/1/2#newcode153
Line 153: command = ['python', local_cpplint, '--filter', filt] + join(files)
On 2009/09/08 07:48:58, Christian Plesner Hansen wrote:
> Above we call cpplint.py as the executable, here we call python explicitly. 
Any
> reason for not letting the script itself decide how to invoke python?

I could not make that work in Windows.

Powered by Google App Engine
This is Rietveld 408576698