Issue 194032: Add more unit tests for perf expectations....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 194032: Add more unit tests for perf expectations.... (Closed)

Created:
11 years, 3 months ago by chase

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/tools/buildbot/scripts/master/

Visibility:
Public.

Description

Add more unit tests for perf expectations. - verify main object is a dictionary - verify load key is present and points to a bool - verify all key values are dictionaries - verify all key values have (correct) delta/var keys - verify all keys are in correct format (a/b/c/d) BUG=18597 TEST=verify unit tests catches these errors

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -98 lines)			Patch
M	log_parser/perf_expectations/PRESUBMIT.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	log_parser/perf_expectations/perf_expectations.json	View	1 chunk	+3 lines, -3 lines	0 comments	Download
A +	log_parser/perf_expectations/tests/perf_expectations_unittest.py	View	2 chunks	+63 lines, -13 lines	0 comments	Download
D	log_parser/perf_expectations/tests/simplejson_unittest.py	View	1 chunk	+0 lines, -81 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

chase

I set load to false so new perf expectation code on the buildbot will not ...

11 years, 3 months ago (2009-09-05 01:41:03 UTC) #1

lgtm, sorry for the delay

Expand Messages | Collapse Messages