Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webkit/glue/webframeloaderclient_impl.cc

Issue 194022: Guard against NULL webview in dispatchDidFinishDocumentLoad. The... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webframeloaderclient_impl.cc
===================================================================
--- webkit/glue/webframeloaderclient_impl.cc (revision 25420)
+++ webkit/glue/webframeloaderclient_impl.cc (working copy)
@@ -320,7 +320,6 @@
void WebFrameLoaderClient::dispatchDidFinishDocumentLoad() {
WebViewImpl* webview = webframe_->GetWebViewImpl();
- WebViewDelegate* d = webview->delegate();
DocumentLoader* documentLoader =
webframe_->frame()->loader()->activeDocumentLoader();
WebDataSourceImpl* data_source =
@@ -330,8 +329,8 @@
// listeners and their associated HTMLInputElements.
webframe_->ClearPasswordListeners();
- if (d)
- d->DidFinishDocumentLoadForFrame(webview, webframe_);
+ if (webview && webview->delegate())
+ webview->delegate()->DidFinishDocumentLoadForFrame(webview, webframe_);
}
bool WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698