Issue 1940002: Prevent chrome extension URL overrides from applying in incognito mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1940002: Prevent chrome extension URL overrides from applying in incognito mode. (Closed)

Created:
10 years, 7 months ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews

Visibility:
Public.

Description

Prevent chrome extension URL overrides from applying in incognito mode. BUG=39372 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46390

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -4 lines)			Patch
	M	chrome/browser/extensions/extension_dom_ui.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download
	M	chrome/browser/extensions/extension_override_apitest.cc	View		3 chunks	+25 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

10 years, 7 months ago (2010-05-04 19:29:48 UTC) #2

LGTM

http://codereview.chromium.org/1940002/diff/1/3
File chrome/browser/extensions/extension_override_apitest.cc (right):

http://codereview.chromium.org/1940002/diff/1/3#newcode62
chrome/browser/extensions/extension_override_apitest.cc:62: {
I don't think you need this {}.  That's in the other tests because of
ResultCatcher.

Expand Messages | Collapse Messages