Issue 1940001: Reverting 2635

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1940001: Reverting 2635 (Closed)

Created:
10 years, 7 months ago by sandholm

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Reverting 2635 Committed: http://code.google.com/p/v8/source/detail?r=4572

Patch Set 5 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	src/ia32/regexp-macro-assembler-ia32.cc	View	1 2 3 4	1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM- http://codereview.chromium.org/1940001/diff/4001/5001 File src/ia32/regexp-macro-assembler-ia32.cc (right): http://codereview.chromium.org/1940001/diff/4001/5001#newcode773 src/ia32/regexp-macro-assembler-ia32.cc:773: __ bind(&check_preempt_label_); Retain the SafeCallTarget abstraction and make ...

10 years, 7 months ago (2010-05-04 08:05:12 UTC) #2

sandholm

10 years, 7 months ago (2010-05-04 08:39:47 UTC) #3

On 2010/05/04 08:05:12, Lasse Reichstein wrote:
> LGTM-
> 
> http://codereview.chromium.org/1940001/diff/4001/5001
> File src/ia32/regexp-macro-assembler-ia32.cc (right):
> 
> http://codereview.chromium.org/1940001/diff/4001/5001#newcode773
> src/ia32/regexp-macro-assembler-ia32.cc:773: __ bind(&check_preempt_label_);
> Retain the SafeCallTarget abstraction and make it just call bind. That will
make
> it easier to change it later if necessary.
done

Expand Messages | Collapse Messages

Issue 1940001: Reverting 2635 (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Messages