Fix issue 65 by making sure not to leak any of the cache...

src/compilation-cache.cc

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 68 matching lines @@
   if (column_offset != script->column_offset()->value()) return false;
   // Check that both names are strings. If not, no match.
   if (!name->IsString() || !script->name()->IsString()) return false;
   // Compare the two name strings for equality.
   return String::cast(*name)->Equals(String::cast(script->name()));
 }
 
 
 static Handle<JSFunction> Lookup(Handle<String> source,
                                  CompilationCache::Entry entry) {
-  Handle<CompilationCacheTable> table = GetTable(entry);
-  Object* result = table->Lookup(*source);
+  // Make sure not to leak the table into the surrounding handle
+  // scope. Otherwise, we risk keeping old tables around even after
+  // having cleared the cache.
+  Object* result;
+  { HandleScope scope;
+    Handle<CompilationCacheTable> table = GetTable(entry);
+    result = table->Lookup(*source);
+  }
   if (result->IsJSFunction()) {
     return Handle<JSFunction>(JSFunction::cast(result));
   } else {
     return Handle<JSFunction>::null();
   }
 }
 
 
 Handle<JSFunction> CompilationCache::LookupScript(Handle<String> source,
                                                   Handle<Object> name,
@@ skipping 21 matching lines @@
   } else {
     Counters::compilation_cache_hits.Increment();
   }
   return result;
 }
 
 
 void CompilationCache::Associate(Handle<String> source,
                                  Entry entry,
                                  Handle<JSFunction> boilerplate) {
+  HandleScope scope;
   ASSERT(boilerplate->IsBoilerplate());
   Handle<CompilationCacheTable> table = GetTable(entry);
   CALL_HEAP_FUNCTION_VOID(table->Put(*source, *boilerplate));
 }
 
 
 void CompilationCache::Clear() {
   for (int i = 0; i < NUMBER_OF_ENTRY_KINDS; i++) {
     tables[i] = Heap::undefined_value();
   }
 }
 
 
 void CompilationCache::Iterate(ObjectVisitor* v) {
   v->VisitPointers(&tables[0], &tables[NUMBER_OF_ENTRY_KINDS]);
 }
 
 
 } }  // namespace v8::internal