Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: src/codegen-ia32.cc

Issue 1938: Fix bug in function context slot lookup. There were two problems: we... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/scopeinfo.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 900 matching lines...) Expand 10 before | Expand all | Expand 10 after
911 Comment cmnt(masm, "[ Store to Property"); 911 Comment cmnt(masm, "[ Store to Property");
912 masm->RecordPosition(position()); 912 masm->RecordPosition(position());
913 Ia32CodeGenerator::SetReferenceProperty(masm, ref, key()); 913 Ia32CodeGenerator::SetReferenceProperty(masm, ref, key());
914 } 914 }
915 915
916 916
917 void VariableProxy::GenerateStoreCode(MacroAssembler* masm, 917 void VariableProxy::GenerateStoreCode(MacroAssembler* masm,
918 Scope* scope, 918 Scope* scope,
919 Reference* ref, 919 Reference* ref,
920 InitState init_state) { 920 InitState init_state) {
921
922 Comment cmnt(masm, "[ Store to VariableProxy"); 921 Comment cmnt(masm, "[ Store to VariableProxy");
923 Variable* node = var(); 922 Variable* node = var();
924 923
925 Expression* expr = node->rewrite(); 924 Expression* expr = node->rewrite();
926 if (expr != NULL) { 925 if (expr != NULL) {
927 expr->GenerateStoreCode(masm, scope, ref, init_state); 926 expr->GenerateStoreCode(masm, scope, ref, init_state);
928 } else { 927 } else {
929 ASSERT(node->is_global()); 928 ASSERT(node->is_global());
930 if (node->AsProperty() != NULL) { 929 if (node->AsProperty() != NULL) {
931 masm->RecordPosition(node->AsProperty()->position()); 930 masm->RecordPosition(node->AsProperty()->position());
(...skipping 4513 matching lines...) Expand 10 before | Expand all | Expand 10 after
5445 bool is_eval) { 5444 bool is_eval) {
5446 Handle<Code> code = Ia32CodeGenerator::MakeCode(fun, script, is_eval); 5445 Handle<Code> code = Ia32CodeGenerator::MakeCode(fun, script, is_eval);
5447 if (!code.is_null()) { 5446 if (!code.is_null()) {
5448 Counters::total_compiled_code_size.Increment(code->instruction_size()); 5447 Counters::total_compiled_code_size.Increment(code->instruction_size());
5449 } 5448 }
5450 return code; 5449 return code;
5451 } 5450 }
5452 5451
5453 5452
5454 } } // namespace v8::internal 5453 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/scopeinfo.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698