Issue 1937003: Pass key in register for keyed load IC...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1937003: Pass key in register for keyed load IC... (Closed)

Created:
10 years, 7 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Pass key in register for keyed load IC The calling convention for keyed load IC is changed to have the key passed both in a register (r0) and on the stack. Next steps will be first to remove the key from the stack and then pass the receiver in a register (r1). Committed: http://code.google.com/p/v8/source/detail?r=4584

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -52 lines)			Patch
M	src/arm/codegen-arm.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/arm/debug-arm.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/arm/full-codegen-arm.cc	View	1	4 chunks	+9 lines, -4 lines	0 comments	Download
M	src/arm/ic-arm.cc	View	1 2 3	9 chunks	+20 lines, -12 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View		7 chunks	+31 lines, -33 lines	0 comments	Download
M	src/arm/virtual-frame-arm.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/1937003/diff/7001/8005 File src/arm/debug-arm.cc (right): http://codereview.chromium.org/1937003/diff/7001/8005#newcode164 src/arm/debug-arm.cc:164: // -- r0 : receiver Indentation. Also, shouldn't ...

10 years, 7 months ago (2010-05-04 19:59:10 UTC) #2

Søren Thygesen Gjesse

10 years, 7 months ago (2010-05-05 06:41:27 UTC) #3

http://codereview.chromium.org/1937003/diff/7001/8005
File src/arm/debug-arm.cc (right):

http://codereview.chromium.org/1937003/diff/7001/8005#newcode164
src/arm/debug-arm.cc:164: //  -- r0    : receiver
On 2010/05/04 19:59:10, Erik Corry wrote:
> Indentation.
> Also, shouldn't that be the key in r0?

Done, yes.

Expand Messages | Collapse Messages