Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1936001: Make bleeding edge compile (r4561 has made the Handle<> ctor explicit) (Closed)

Created:
10 years, 7 months ago by Dmitry Titov
Modified:
9 years ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Make bleeding edge compile (since r4561 made Handle ctor explicit)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/d8.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Titov
I'm not a project member, so I won't be able to commit it. I guess ...
10 years, 7 months ago (2010-05-04 05:40:13 UTC) #1
Erik Corry
LGTM, thanks for the patch.
10 years, 7 months ago (2010-05-04 07:27:01 UTC) #2
Erik Corry
10 years, 7 months ago (2010-05-04 07:28:49 UTC) #3
On 2010/05/04 07:27:01, Erik Corry wrote:
> LGTM, thanks for the patch.

Committed as bleeding edge 4570.

Powered by Google App Engine
This is Rietveld 408576698