src/x64/macro-assembler-x64.cc - Issue 1934004: Correct bug with left shift on X64 platform from change 4571 (http://code.goo...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/macro-assembler-x64.cc

Issue 1934004: Correct bug with left shift on X64 platform from change 4571 (http://code.goo... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/macro-assembler-x64.cc

===================================================================

--- src/x64/macro-assembler-x64.cc (revision 4596)

+++ src/x64/macro-assembler-x64.cc (working copy)

@@ -1227,8 +1227,7 @@

void MacroAssembler::SmiShiftLeftConstant(Register dst,

- int shift_value,

- Label* on_not_smi_result) {

+ int shift_value) {

if (!dst.is(src)) {

movq(dst, src);

}

@@ -1240,8 +1239,7 @@

void MacroAssembler::SmiShiftLeft(Register dst,

- Register src2,

- Label* on_not_smi_result) {

+ Register src2) {

ASSERT(!dst.is(rcx));

Label result_ok;

// Untag shift amount.

« no previous file with comments | « src/x64/macro-assembler-x64.h ('k') | test/cctest/test-macro-assembler-x64.cc » ('j') | no next file with comments »