Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: src/heap.h

Issue 1933: Generalized the EvalCache into a CompilationCache and enabled... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/compilation-cache.h ('K') | « src/handles.cc ('k') | src/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap.h
===================================================================
--- src/heap.h (revision 268)
+++ src/heap.h (working copy)
@@ -122,10 +122,9 @@
V(Code, c_entry_debug_break_code) \
V(FixedArray, number_string_cache) \
V(FixedArray, single_character_string_cache) \
- V(FixedArray, natives_source_cache) \
- V(Object, eval_cache_global) \
- V(Object, eval_cache_non_global)
+ V(FixedArray, natives_source_cache)
+
#define ROOT_LIST(V) \
STRONG_ROOT_LIST(V) \
V(Object, symbol_table)
@@ -531,28 +530,6 @@
}
static Object* LookupSymbol(String* str);
- // EvalCache caches function boilerplates for compiled scripts
- // from 'eval' function.
- // Source string is used as the key, and compiled function
- // boilerplate as value. Because the same source has different
- // compiled code in global or local context, we use separate
- // caches for global and local contexts.
- // Caches are cleared before mark-compact/mark-sweep GC's.
-
- // Finds the function boilerplate of a source string.
- // It returns a JSFunction object if found in the cache.
- // The first parameter specifies whether the code is
- // compiled in a global context.
- static Object* LookupEvalCache(bool is_global_context, String* src);
-
- // Put a source string and its compiled function boilerplate
- // in the eval cache. The cache may expand, and returns failure
- // if it cannot expand the cache, otherwise the value is returned.
- // The first parameter specifies whether the boilerplate is
- // compiled in a global context.
- static Object* PutInEvalCache(bool is_global_context,
- String* src, JSFunction* value);
-
// Compute the matching symbol map for a string if possible.
// NULL is returned if string is in new space or not flattened.
static Map* SymbolMapForString(String* str);
« src/compilation-cache.h ('K') | « src/handles.cc ('k') | src/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698