Issue 193128: Use MAC_OS_X_DEPLOYMENT_TARGET instead of rolling our own

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 193128: Use MAC_OS_X_DEPLOYMENT_TARGET instead of rolling our own (Closed)

Created:
11 years, 3 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com, John Grabowski, brettw, pam+watch_chromium.org, maf, Greg Spencer, Hironori Bono

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Use MAC_OS_X_DEPLOYMENT_TARGET instead of rolling our own macro. Allow the deployment target and SDK to be overridden by GYP variables. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26360

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -38 lines)			Patch
M	base/compat_execinfo.h	View		1 chunk	+19 lines, -15 lines	0 comments	Download
M	base/file_util_posix.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	build/common.gypi	View	1	2 chunks	+21 lines, -21 lines	0 comments	Download
M	o3d/DEPS_gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

TVL

http://codereview.chromium.org/193128/diff/1/3 File build/common.gypi (right): http://codereview.chromium.org/193128/diff/1/3#newcode631 Line 631: 'SDKROOT': 'macosx10.6', # -isysroot 10.6?

11 years, 3 months ago (2009-09-16 16:50:52 UTC) #2

Mark Mentovai

TVL wrote: > http://codereview.chromium.org/193128/diff/1/3#newcode631 > Line 631: 'SDKROOT': 'macosx10.6', # -isysroot > 10.6? Look again, ...

11 years, 3 months ago (2009-09-16 16:52:41 UTC) #3

lgtm

Expand Messages | Collapse Messages