Issue 193118: Revert "First part of automated_ui_tests improvements."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 193118: Revert "First part of automated_ui_tests improvements." (Closed)

Created:
11 years, 3 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
huanr

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Revert "First part of automated_ui_tests improvements." Revert "Fix Mac by disabling some UI tests on it." Too many failures. TBR=huanr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26281

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -202 lines)			Patch
M	chrome/browser/automation/automation_provider.cc	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	chrome/test/automated_ui_tests/automated_ui_test_base.h	View	3 chunks	+0 lines, -27 lines	0 comments	Download
M	chrome/test/automated_ui_tests/automated_ui_test_base.cc	View	3 chunks	+0 lines, -46 lines	0 comments	Download
M	chrome/test/automated_ui_tests/automated_ui_test_test.cc	View	3 chunks	+0 lines, -99 lines	0 comments	Download
M	chrome/test/automated_ui_tests/automated_ui_tests.h	View	2 chunks	+30 lines, -0 lines	0 comments	Download
M	chrome/test/automated_ui_tests/automated_ui_tests.cc	View	3 chunks	+28 lines, -2 lines	0 comments	Download
M	chrome/test/ui/ui_test.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/tools/automated_ui_test_tools/auto_ui_test_input_generator.py	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/tools/automated_ui_test_tools/possible_actions.txt	View	2 chunks	+1 line, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

Paweł Hajdan Jr.

TBR It reverts my previous "fix" too. I was too sloppy with not running the ...

11 years, 3 months ago (2009-09-15 22:26:59 UTC) #1

OK