Issue 193112: Added test suite adapter for es5conform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 193112: Added test suite adapter for es5conform. (Closed)

Created:
11 years, 3 months ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Added test suite adapter for es5conform.

Patch Set 3 : regression-test #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+267 lines, -2 lines)			Patch
M	src/bootstrapper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/v8natives.js	View		1 chunk	+1 line, -1 line	0 comments	Download
A	test/es5conform/README	View		1 chunk	+14 lines, -0 lines	0 comments	Download
A	test/es5conform/es5conform.status	View		1 chunk	+68 lines, -0 lines	0 comments	Download
A	test/es5conform/harness-adapt.js	View	1	1 chunk	+74 lines, -0 lines	2 comments	Download
A	test/es5conform/testcfg.py	View		1 chunk	+108 lines, -0 lines	0 comments	Download
M	test/mjsunit/third_party/object-keys.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/193112/diff/3001/4005 File test/es5conform/harness-adapt.js (right): http://codereview.chromium.org/193112/diff/3001/4005#newcode30 Line 30: function ES5Error(ut) { Use a better name ...

11 years, 3 months ago (2009-09-15 13:27:34 UTC) #2

Christian Plesner Hansen

11 years, 3 months ago (2009-09-15 13:30:06 UTC) #3

http://codereview.chromium.org/193112/diff/3001/4005
File test/es5conform/harness-adapt.js (right):

http://codereview.chromium.org/193112/diff/3001/4005#newcode30
Line 30: function ES5Error(ut) {
No.  Ut af mit kode review!

Expand Messages | Collapse Messages

Issue 193112: Added test suite adapter for es5conform. (Closed)

Description

Patch Set 1 #

Patch Set 2 : copyright #

Patch Set 3 : regression-test #

Messages