Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 193110: Disable tabs.relativeUrlTabsUpdate ran in ExtensionApiTest.Tabs until it beco... (Closed)

Created:
11 years, 3 months ago by tyoshino (SeeGerritForStatus)
Modified:
9 years, 7 months ago
Reviewers:
rafaelw
CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr., agl
Visibility:
Public.

Description

Disable tabs.relativeUrlTabsUpdate ran in ExtensionApiTest.Tabs until it becomes not flaky. It seems that this was not caused by other changes but the test was flaky originally. The build on which this failure occurred for the first time is 11102. There were four successful builds after the test was added: 11098, 11099, 11100, 11101. http://build.chromium.org/buildbot/waterfall/builders/Vista%20Tests/builds/11102 BUG=21851 TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/test/data/extensions/api_test/tabs/test.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tyoshino (SeeGerritForStatus)
11 years, 3 months ago (2009-09-15 14:17:03 UTC) #1
rafaelw
maruel beat you too it. =-). thanks, though! btw, only disabling relativeUrlTabsUpdate, like you did ...
11 years, 3 months ago (2009-09-15 17:16:46 UTC) #2
tyoshino (SeeGerritForStatus)
11 years, 3 months ago (2009-09-16 14:02:31 UTC) #3
On 2009/09/15 17:16:46, rafaelw wrote:
> maruel beat you too it. =-). thanks, though! btw, only disabling
> relativeUrlTabsUpdate, like you did here, was the preferable way to do this.
> 
> http://codereview.chromium.org/205009

OK. I saw that you splitted the test Today. Thanks.

Powered by Google App Engine
This is Rietveld 408576698