Issue 193109: Potential fix for http://crbug.com/13111

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 193109: Potential fix for http://crbug.com/13111 (Closed)

Created:
11 years, 3 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
jeremy

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Potential fix for http://crbug.com/13111 The browser_window_controller is destroyed before the window is destroyed. In its dealloc, it sends the download shelf an |exiting| message that deletes all item controllers, but the items's views might still be visible and hold weak references to their controllers. When they are clicked, they would se nd a message to free'd memory. This is all speculation. BUG=13111 TEST=Release to dev channel, monitor crash reports. Should go down. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26198

Patch Set 1 #

Created: 11 years, 3 months ago

		Unified diffs	Side-by-side diffs	Stats (+1 line, -0 lines)
	M	chrome/browser/cocoa/download_item_controller.mm	View	1 chunk	+1 line, -0 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

I haven't tested it yet – I just synced, and compiling takes several hours. The ...

11 years, 3 months ago (2009-09-15 05:34:32 UTC) #2

LGTM

Expand Messages | Collapse Messages