Pause for <video> should have immediate effect on audio

Pause for <video> should have immediate effect on audio

BUG=20351
A bug found while fixing mac audio. IPCAudioSouce transist to a
wrong state after Play() is called. Resulting to pause having
no effect. This will solve the problem of audio keeps playing
a while after it is paused.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26500

[Alpha Left Google, 2009-09-13 19:50:20]

This will solve the problem of pause, but introduce a very bad behavior for
still2.ogv when playing in loop mode. Since FFmpeg has bug about seeking for
ogg, after still2.ogv is played once, seeking to beginning would result in no
data at all, the end result is renderer will keep firing pause / start  to the
browser and since pause on windows is a blocking action, playing such file would
hang the browser.

I'll file a bug for this once this is checked in.

[scherkus (not reviewing), 2009-09-17 03:23:59]

nits, but you can decide what's better -- LGTM!

http://codereview.chromium.org/193095/diff/1/3
File media/audio/win/waveout_output_win.cc (right):

http://codereview.chromium.org/193095/diff/1/3#newcode145
Line 145: pending_bytes_ = 0;
hmm would it make more sense to set this in Stop() when we're positive that
pending_bytes_ has reached zero?

http://codereview.chromium.org/193095/diff/1/3#newcode176
Line 176: // or else the waveOutReset will deadlock and secondly, the callback
should not
nit: waveOutReset -> waveOutReset()