Issue 193086: Fix printing project on linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 193086: Fix printing project on linux. (Closed)

Created:
11 years, 3 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix printing project on linux. Enable compilation of every files and fix tests. TEST=unit tests BUG=9847 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26103

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix mac compile #

Patch Set 3 : fix git error #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -67 lines)			Patch
M	printing/native_metafile.h	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	printing/page_overlays.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	printing/page_overlays.cc	View		3 chunks	+3 lines, -6 lines	0 comments	Download
M	printing/page_overlays_unittest.cc	View	1	3 chunks	+16 lines, -17 lines	0 comments	Download
M	printing/pdf_ps_metafile_linux_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	printing/printed_document.cc	View		11 chunks	+25 lines, -7 lines	0 comments	Download
M	printing/printing.gyp	View		3 chunks	+13 lines, -29 lines	0 comments	Download
M	printing/run_all_unittests.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

11 years, 3 months ago (2009-09-11 19:14:38 UTC) #2

LGTM!

http://codereview.chromium.org/193086/diff/1/4
File printing/page_overlays_unittest.cc (right):

http://codereview.chromium.org/193086/diff/1/4#newcode73
Line 73: std::wstring expected = StringPrintf(L"foo%lsbar",
kOverlayKeys[i].expected);
Nit: 80 cols.

Expand Messages | Collapse Messages