Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9818)

Unified Diff: chrome/test/v8_unit_test.h

Issue 193072: Move StringPiece into the base namespace. It is colliding (Closed)
Patch Set: take 2 Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/user_script_slave.cc ('k') | chrome/test/v8_unit_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/v8_unit_test.h
diff --git a/chrome/test/v8_unit_test.h b/chrome/test/v8_unit_test.h
index 1502e9d177c265e964abb3e1f66740890de1a501..644c660e8ed92efa917ca8804d43e17eff7f21dd 100644
--- a/chrome/test/v8_unit_test.h
+++ b/chrome/test/v8_unit_test.h
@@ -10,7 +10,9 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "v8/include/v8.h"
+namespace base {
class StringPiece;
+}
// A superclass for unit tests that involve running JavaScript. This class
// sets up V8 context and has methods that make it easy to execute scripts in
@@ -23,8 +25,8 @@ class V8UnitTest : public testing::Test {
protected:
// Executes the given script source in the context. The specified script
// name is used when reporting errors.
- virtual void ExecuteScriptInContext(const StringPiece& script_source,
- const StringPiece& script_name);
+ virtual void ExecuteScriptInContext(const base::StringPiece& script_source,
+ const base::StringPiece& script_name);
// Converts a v8::TryCatch into a human readable string.
virtual std::string ExceptionToString(v8::TryCatch* try_catch);
« no previous file with comments | « chrome/renderer/user_script_slave.cc ('k') | chrome/test/v8_unit_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698