Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/browser/history/history.cc

Issue 193071: The chrome://* address are not being added to the history DB, and as such the... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history.cc
===================================================================
--- chrome/browser/history/history.cc (revision 25857)
+++ chrome/browser/history/history.cc (working copy)
@@ -615,16 +615,16 @@
if (!url.is_valid())
return false;
+ // We allow chrome://* URLs so that they will be added to history and
+ // autocomplete suggestions.
if (url.SchemeIs(chrome::kJavaScriptScheme) ||
- url.SchemeIs(chrome::kChromeUIScheme) ||
url.SchemeIs(chrome::kViewSourceScheme) ||
url.SchemeIs(chrome::kChromeInternalScheme) ||
url.SchemeIs(chrome::kPrintScheme))
return false;
if (url.SchemeIs(chrome::kAboutScheme)) {
- std::string path = url.path();
- if (path.empty() || LowerCaseEqualsASCII(path, "blank"))
+ if (LowerCaseEqualsASCII(url.path(), "blank"))
return false;
// We allow all other about URLs since the user may like to see things
// like "about:memory" or "about:histograms" in their history and
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698