The chrome://* address are not being added to the history DB, and as such the...

The chrome://* address are not being added to the history DB, and as such they are not being autocompleted in the location bar. The about://* are being added with the exception of about://blank.

BUG=2958
TEST=None

[Peter Kasting, 2009-09-10 18:33:46]

I added Brett and Darin as reviewers because I'm not sure what subtle effects
allowing these in history might have.

http://codereview.chromium.org/193071/diff/1/2
File chrome/browser/history/history.cc (right):

http://codereview.chromium.org/193071/diff/1/2#newcode627
Line 627: std::string path = url.path();
This should also be fixed to remove the empty() check:

if (LowerCaseEqualsASCII(url.path(), "blank"))...

[pierre.lafayette, 2009-09-10 18:41:51]

http://codereview.chromium.org/193071/diff/1/2
File chrome/browser/history/history.cc (right):

http://codereview.chromium.org/193071/diff/1/2#newcode627
Line 627: std::string path = url.path();
On 2009/09/10 18:33:46, Peter Kasting wrote:
> This should also be fixed to remove the empty() check:
> 
> if (LowerCaseEqualsASCII(url.path(), "blank"))...

Done.

[brettw, 2009-09-10 22:50:31]

http://codereview.chromium.org/193071/diff/1/2
File chrome/browser/history/history.cc (right):

http://codereview.chromium.org/193071/diff/1/2#newcode627
Line 627: std::string path = url.path();
What did you mean. I'm actually not sure what the empty check is for, but are
you adding that "about:" should be added to history?

[Peter Kasting, 2009-09-10 22:58:57]

http://codereview.chromium.org/193071/diff/1/2
File chrome/browser/history/history.cc (right):

http://codereview.chromium.org/193071/diff/1/2#newcode627
Line 627: std::string path = url.path();
On 2009/09/10 22:50:31, brettw wrote:
> What did you mean. I'm actually not sure what the empty check is for, but are
> you adding that "about:" should be added to history?

Yes, that's what the bug is about.

[brettw, 2009-09-11 00:18:06]

On 2009/09/10 22:58:57, Peter Kasting wrote:
> http://codereview.chromium.org/193071/diff/1/2
> File chrome/browser/history/history.cc (right):
> 
> http://codereview.chromium.org/193071/diff/1/2#newcode627
> Line 627: std::string path = url.path();
> On 2009/09/10 22:50:31, brettw wrote:
> > What did you mean. I'm actually not sure what the empty check is for, but
are
> > you adding that "about:" should be added to history?
> 
> Yes, that's what the bug is about.

Ah, I thought the bug meant "about:" URLs and not THE "about:" URL.

I can't think of any problems, LGTM

[pierre.lafayette, 2009-09-18 19:29:10]

ping Darin.

On 2009/09/11 00:18:06, brettw wrote:
> On 2009/09/10 22:58:57, Peter Kasting wrote:
> > http://codereview.chromium.org/193071/diff/1/2
> > File chrome/browser/history/history.cc (right):
> > 
> > http://codereview.chromium.org/193071/diff/1/2#newcode627
> > Line 627: std::string path = url.path();
> > On 2009/09/10 22:50:31, brettw wrote:
> > > What did you mean. I'm actually not sure what the empty check is for, but
> are
> > > you adding that "about:" should be added to history?
> > 
> > Yes, that's what the bug is about.
> 
> Ah, I thought the bug meant "about:" URLs and not THE "about:" URL.
> 
> I can't think of any problems, LGTM

[Peter Kasting, 2009-09-24 21:55:12]

Landed in r27131.