Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 193070: Rebaseline more of fast/repaint tests we are now passing (part 6)... (Closed)

Created:
11 years, 3 months ago by dglazkov
Modified:
9 years, 6 months ago
Reviewers:
Julie Parent
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Rebaseline more of fast/repaint tests we are now passing (part 6) The difference between repaint areas is due to the difference in repaint logic. Safari/Mac port uses NSView's native rectangle collection/unification, and we just unify all into one damage rect. R=jparent BUG=8630 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25872

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -13 lines) Patch
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/canvas/canvas-as-image-incremental-repaint-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/frames/inline-object-inside-frameset-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/frames/inline-object-inside-frameset-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/layers/add-layer-with-nested-stacking-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/layers/inline-dirty-z-order-lists-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/layers/inline-dirty-z-order-lists-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/layers/remove-layer-with-nested-stacking-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/layers/remove-layer-with-nested-stacking-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/replaced/width100percent-button-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/replaced/width100percent-button-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/replaced/width100percent-button-expected.txt View 1 chunk +53 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/table/empty-section-crash-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/table/empty-section-crash-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/canvas-as-image-incremental-repaint-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/canvas-as-image-incremental-repaint-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/frames/inline-object-inside-frameset-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/frames/inline-object-inside-frameset-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/frames/inline-object-inside-frameset-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/add-layer-with-nested-stacking-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/add-layer-with-nested-stacking-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/inline-dirty-z-order-lists-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/inline-dirty-z-order-lists-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/inline-dirty-z-order-lists-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/remove-layer-with-nested-stacking-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/remove-layer-with-nested-stacking-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/remove-layer-with-nested-stacking-expected.txt View 1 chunk +20 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/width100percent-button-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/width100percent-button-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/width100percent-button-expected.txt View 1 chunk +53 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/empty-section-crash-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/empty-section-crash-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/empty-section-crash-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dglazkov
11 years, 3 months ago (2009-09-10 17:06:35 UTC) #1
dglazkov
That's it for obvious passes. Up next -- the non-obvious ones :)
11 years, 3 months ago (2009-09-10 17:07:12 UTC) #2
Julie Parent
11 years, 3 months ago (2009-09-10 17:30:34 UTC) #3 
LGTM

Powered by Google App Engine
This is Rietveld 408576698