Issue 193067: Strict transport security: come out from behind the flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 193067: Strict transport security: come out from behind the flag. (Closed)

Created:
11 years, 3 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
abarth-chromium

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Strict transport security: come out from behind the flag. With this change, Strict Transport Security is active by default and doesn't need the --force-https flag any more.

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -24 lines)			Patch
M	base/base_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/base_switches.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	net/url_request/url_request_http_job.cc	View	3 chunks	+1 line, -13 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

11 years, 3 months ago (2009-09-10 00:59:02 UTC) #2

LGTM!  Exciting times in Ridgemont High!

http://codereview.chromium.org/193067/diff/1/4
File net/url_request/url_request_http_job.cc (right):

http://codereview.chromium.org/193067/diff/1/4#newcode52
Line 52: request->url().host())) {
I'm slightly worried about the performance implications of this check.   Please
watch the perf charts to make sure this is ok.

Expand Messages | Collapse Messages