Issue 193066: Get rid of all query parameters since the http server for src.chromium.org...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 193066: Get rid of all query parameters since the http server for src.chromium.org... (Closed)

Created:
11 years, 3 months ago by ojan

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Get rid of all query parameters since the http server for src.chromium.org throws a 500 when there is an unsupported query parameter. Use hash parameters for everything instead. TBR since the dashboard is broken until this is checked in. TBR=arv@chromium.org BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25824

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -38 lines)			Patch
	M	webkit/tools/layout_tests/flakiness_dashboard.html	View		9 chunks	+22 lines, -38 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

11 years, 3 months ago (2009-09-10 00:25:12 UTC) #2

http://codereview.chromium.org/193066/diff/1/2
File webkit/tools/layout_tests/flakiness_dashboard.html (right):

http://codereview.chromium.org/193066/diff/1/2#newcode1198
Line 1198: 'showCorrectExpectations', 'showFlaky: true', 'maxResults'];
fix indentation

Expand Messages | Collapse Messages