Issue 193049: linux: add a suppression for a leak when we load a third-party plugin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 193049: linux: add a suppression for a leak when we load a third-party plugin (Closed)

Created:
11 years, 3 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, dank

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

linux: add a suppression for a leak when we load a third-party plugin

Patch Set 4 : comment fix #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View	1 2 3	1 chunk	+16 lines, -0 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

http://codereview.chromium.org/193049/diff/3001/3002 File tools/valgrind/memcheck/suppressions.txt (right): http://codereview.chromium.org/193049/diff/3001/3002#newcode267 Line 267: fun:realloc also need one for calloc http://codereview.chromium.org/193049/diff/3001/3002#newcode273 Line ...

11 years, 3 months ago (2009-09-08 23:29:07 UTC) #3

dkegel

On Tue, Sep 8, 2009 at 4:29 PM, <thestig@chromium.org> wrote: > http://codereview.chromium.org/193049/diff/3001/3002#newcode267 > Line 267: ...

11 years, 3 months ago (2009-09-09 04:14:40 UTC) #4

dkegel

11 years, 3 months ago (2009-09-09 04:14:59 UTC) #5

On Tue, Sep 8, 2009 at 9:14 PM, Dan Kegel<dkegel@google.com> wrote:
> On Tue, Sep 8, 2009 at 4:29 PM, <thestig@chromium.org> wrote:
>> http://codereview.chromium.org/193049/diff/3001/3002#newcode267
>> Line 267: fun:realloc
>> also need one for calloc
>
> The fun:* wildcard may come in handy here

Or just give up and let the ... handle that, too.

Expand Messages | Collapse Messages

Issue 193049: linux: add a suppression for a leak when we load a third-party plugin (Closed)

Description

Patch Set 1 #

Patch Set 2 : bug #

Patch Set 3 : retry #

Patch Set 4 : comment fix #

Messages