Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: webkit/glue/plugins/plugin_lib_unittest.cc

Issue 193046: linux: write a unit test for plugin mime parsing (Closed)
Patch Set: japanese Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/plugins/plugin_lib_linux.cc ('k') | webkit/tools/test_shell/test_shell.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/plugins/plugin_lib_unittest.cc
diff --git a/webkit/glue/plugins/plugin_lib_unittest.cc b/webkit/glue/plugins/plugin_lib_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d2de72efe89aa11ee210296205bd249e87dcd045
--- /dev/null
+++ b/webkit/glue/plugins/plugin_lib_unittest.cc
@@ -0,0 +1,71 @@
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "webkit/glue/plugins/plugin_lib.h"
+
+#include "build/build_config.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+#if defined(OS_LINUX)
+
+// Test parsing a simple description: Real Audio.
+TEST(MIMEDescriptionParse, Simple) {
+ std::vector<WebPluginMimeType> types;
+ ASSERT_TRUE(NPAPI::PluginLib::ParseMIMEDescription(
+ "audio/x-pn-realaudio-plugin:rpm:RealAudio document;",
+ &types));
+ ASSERT_EQ(1U, types.size());
+ const WebPluginMimeType& type = types[0];
+ EXPECT_EQ("audio/x-pn-realaudio-plugin", type.mime_type);
+ ASSERT_EQ(1U, type.file_extensions.size());
+ EXPECT_EQ("rpm", type.file_extensions[0]);
+ EXPECT_EQ(L"RealAudio document", type.description);
+}
+
+// Test parsing a multi-entry description: QuickTime as provided by Totem.
+TEST(MIMEDescriptionParse, Multi) {
+ std::vector<WebPluginMimeType> types;
+ ASSERT_TRUE(NPAPI::PluginLib::ParseMIMEDescription(
+ "video/quicktime:mov:QuickTime video;video/mp4:mp4:MPEG-4 "
+ "video;image/x-macpaint:pntg:MacPaint Bitmap image;image/x"
+ "-quicktime:pict, pict1, pict2:QuickTime image;video/x-m4v"
+ ":m4v:MPEG-4 video;",
+ &types));
+
+ ASSERT_EQ(5U, types.size());
+
+ // Check the x-quicktime one, since it looks tricky with spaces in the
+ // extension list.
+ const WebPluginMimeType& type = types[3];
+ EXPECT_EQ("image/x-quicktime", type.mime_type);
+ ASSERT_EQ(3U, type.file_extensions.size());
+ EXPECT_EQ("pict2", type.file_extensions[2]);
+ EXPECT_EQ(L"QuickTime image", type.description);
+}
+
+// Test parsing a Japanese description, since we got this wrong in the past.
+// This comes from loading Totem with LANG=ja_JP.UTF-8.
+TEST(MIMEDescriptionParse, JapaneseUTF8) {
+ std::vector<WebPluginMimeType> types;
+ ASSERT_TRUE(NPAPI::PluginLib::ParseMIMEDescription(
+ "audio/x-ogg:ogg:Ogg \xe3\x82\xaa\xe3\x83\xbc\xe3\x83\x87"
+ "\xe3\x82\xa3\xe3\x83\xaa",
+ &types));
+
+ ASSERT_EQ(1U, types.size());
+ // Check we got the right number of Unicode characters out of the parse.
+ EXPECT_EQ(9U, types[0].description.size());
+}
+
+/*
+
+TODO(evanm): write a test that covers the following, which does *not*
+parse properly with the current code.
+
+application/x-java-vm:class,jar:IcedTea;application/x-java-applet:class,jar:IcedTea;application/x-java-applet;version=1.1:class,jar:IcedTea;application/x-java-applet;version=1.1.1:class,jar:IcedTea;application/x-java-applet;version=1.1.2:class,jar:IcedTea;application/x-java-applet;version=1.1.3:class,jar:IcedTea;application/x-java-applet;version=1.2:class,jar:IcedTea;application/x-java-applet;version=1.2.1:class,jar:IcedTea;application/x-java-applet;version=1.2.2:class,jar:IcedTea;application/x-java-applet;version=1.3:class,jar:IcedTea;application/x-java-applet;version=1.3.1:class,jar:IcedTea;application/x-java-applet;version=1.4:class,jar:IcedTea
+ */
+
+
+#endif // defined(OS_LINUX)
+
« no previous file with comments | « webkit/glue/plugins/plugin_lib_linux.cc ('k') | webkit/tools/test_shell/test_shell.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698